[
https://issues.apache.org/jira/browse/AVRO-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. updated AVRO-134:
-------------------------------------
Attachment: AVRO-134.patch
Here is a new patch.
- It uses "null" instead of "raw" as the name of the codec.
- If there is no key by name "codec" null is assumed
- I left the DataFileConstants as a class. As Doug pointed out, having it as
an interface and deriving from it will require it be made public. We can, even
with interface, continue to use the constants the same way use now, but then
interface doesn't buy you anything. A third option is to statically import
those constants, but I'm not a big fan of static imports.
> Mismatch between the spec and implementation of metadata blocks in files
> ------------------------------------------------------------------------
>
> Key: AVRO-134
> URL: https://issues.apache.org/jira/browse/AVRO-134
> Project: Avro
> Issue Type: Bug
> Reporter: Thiruvalluvan M. G.
> Attachments: AVRO-134.patch, AVRO-134.patch
>
>
> The spec says there are three keys in metadata blocks - schema, count and
> _codec_. But the code in DataFileWriter adds schema, count and _sync_. The
> sync field is used by the DataFileReader. We need to do the following:
> - Add the key sync in the specification.
> - Either drop the key codec in the specification or add code to support
> codec in DataFileReader/DataFileWriter. If we decide to have codec, we need
> to also publish in the spec the list of supported codecs with their names to
> use in the metadata block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
