At 1245947013 time_t, Gregor Best wrote:
> > > Subject: [PATCH 10/12] systray: don't crap up on odd-sized windows
> > > diff --git a/widgets/systray.c b/widgets/systray.c
> > > index 0504be8..bd53ef6 100644
> > > --- a/widgets/systray.c
> > > +++ b/widgets/systray.c
> > > @@ -32,32 +32,27 @@
> > > #define _NET_SYSTEM_TRAY_ORIENTATION_HORZ 0
> > > #define _NET_SYSTEM_TRAY_ORIENTATION_VERT 1
> > >
> > > +typedef struct
> > > +{
> > > + /* systray height */
> > > + int height;
> > > +} systray_data_t;
> > > +
> >
> > Uhm, do we really need a struct for this?
> >
>
> I wanted to stay consistent with the rest of the widgets, but as the
> number of widgets in the C core is reduced, that might not be neccessary
> anymore. JD: comments?Actually, this struct is reduced to an int anyway since it only got that inside. So there's not point code-wise speaking to change that (i.e. there's no optimization to make). I'd say leave it as it is, as a struct, 'cause there's always a chance we'll need to store something more than the height. So there's a chance we will re-add a struct later. And its somehow consistent with other widgets, so it's not a problem to me. > > > > Subject: [PATCH 11/12] awful.util: add table.clone > > > > That's a nice, small patch, it's a candidate for merging independent of > > widget > > layouts. :) > > > > If you really need it :P > > > > Subject: [PATCH 12/12] widget.layout.*: correctly stack nested layouts > > > > A bugfix in the very first patch series? I'd propose to merge this stuff > > with > > the patches which added this code > > > > Agreed, these patches are my current working branch, so expect some > splitting and reordering. > > > I hope I didn't annoy you too much. > > > > Nope, your feedback is very much appreciated, as well as everyone elses, > thanks a lot :) > > -- > GCS/IT/M d- s+:- a--- C++ UL+++ US UB++ P+++ L+++ E--- W+ N+ o-- > K- w--- O M-- V PS+ PE- Y+ PGP+++ t+ 5 X+ R tv+ b++ DI+++ D+++ G+ > e- h! r y+ > > Gregor Best -- Julien Danjou // ᐰ <jul...@danjou.info> http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // And thinking so much differently.
signature.asc
Description: Digital signature
