This is review of patch #3.
At 1245932662 time_t, Gregor Best wrote:
> -- vim:
> filetype=lua:expandtab:shiftwidth=4:tabstop=8:softtabstop=4:encoding=utf-8:textwidth=80
> diff --git a/lib/awful/widget/init.lua.in b/lib/awful/widget/init.lua.in
> index 6d4b51c..ae0cfb2 100644
> --- a/lib/awful/widget/init.lua.in
> +++ b/lib/awful/widget/init.lua.in
> @@ -13,6 +13,8 @@ require("awful.widget.progressbar")
> require("awful.widget.graph")
> require("awful.widget.layoutbox")
>
> +require("awful.widget.layout")
> +
Drop the empty line above.
> + for _, k in ipairs(util.table.ikeys(widgets)) do
I did not dig too far, but isn'y ipairs enough?
> diff --git a/lib/awful/widget/taglist.lua.in b/lib/awful/widget/taglist.lua.in
> index 00de38c..6117942 100644
> --- a/lib/awful/widget/taglist.lua.in
> +++ b/lib/awful/widget/taglist.lua.in
> @@ -48,7 +48,7 @@ end
> -- @param label Label function to use.
> -- @param buttons A table with buttons binding to set.
> function new(screen, label, buttons)
> - local w = {}
> + local w = { }
> local widgets = { }
> widgets.imagebox = { }
> widgets.textbox = { ["margin"] = { ["left"] = 0,
> diff --git a/lib/awful/widget/tasklist.lua.in
> b/lib/awful/widget/tasklist.lua.in
> index 0d0897c..883a12d 100644
> --- a/lib/awful/widget/tasklist.lua.in
> +++ b/lib/awful/widget/tasklist.lua.in
> @@ -42,7 +42,7 @@ end
> -- @param label Label function to use.
> -- @param buttons A table with buttons binding to set.
> function new(label, buttons)
> - local w = {}
> + local w = { }
> local widgets = { }
> widgets.imagebox = { align = "flex" }
> widgets.textbox = { align = "flex",
Remove that crap. :)
--
Julien Danjou
// ᐰ <jul...@danjou.info> http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
// Anna Molly! Anna Molly! Anna Molly!
signature.asc
Description: Digital signature
