On Wed, Sep 2, 2009 at 16:39, Julien Danjou<jul...@danjou.info> wrote: > At 1251904856 time_t, koniu wrote: >> There's incremental commits that will eventually be squashed. > Please do so if you think it reduce the review size. ;)
I'll keep the increments for now, since it's easier for me to track progress and squash them when we'll be getting closer to finalizing the review. >> > - just implement a callback system where you give a function to >> > awful.doc that will be called with text to be printed as argument. >> >> That's what I was thinking. Question is, where ought the default >> callback function(s) be defined. Actually, looking at the extent of naughty dependency (and therefore a necessity to do a lot of different callbacks) I'm leaning towards your first suggestion which is splitting it out of awful and calling it 'handy' instead (unless someone has a better name - ideas welcome). > >> Another small issue - awful.help.get(widget) doesn't get descriptions >> for 'buttons' and 'extents': http://omploader.org/vMjlvYg. > We should probably export object methods to their "module" also: > mywidget:buttons() and mywidget.buttons(mywidget) already > That's something I can add as soon as I've time, if no one goes into it > before me. That would be great. I'll leave this to you (or whomever wants to boost their commit rank, hint hint psychon :p). kk -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
