On Fri, May 21 2010, Daniel Graña wrote:

> Agree, but I tried hard to follow it, where I failed?

I don't know; I actually only read the patch on github, and had the
impression the indentation was wrong. But I may be wrong about that. :)

> Cool, latest patch http://gist.github.com/409014
> I did the changes you suggested and reused the "screent_t screen" variable
> where possible.

Loooks good.

It would be nice if some people could torture the patch though.

>> Do you plan to make an extra patch to unregister the systray when the
>> widget disappear ?
>>
>
> Prefer to do it in one patch, but can't find what is the best place to
> unregister systray.

The more you split your work, the happier I am.

> What call systray widget destructor?

luaA_widget_gc, which call the widget destructor.
Note that you will have to count the systray widgets.

-- 
Julien Danjou
// ᐰ <[email protected]>   http://julien.danjou.info

Attachment: pgpNEJxQ01Y3o.pgp
Description: PGP signature

Reply via email to