-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 16.06.2010 23:56, Jim Pryor wrote: > On Wed, Jun 16, 2010 at 10:30:17PM +0200, Uli Schlachter wrote: [..] > And indeed, git bisecting reports: > >> 38edc5809755b4623b30bcb1838360d29d86b789 is the first bad commit >> commit 38edc5809755b4623b30bcb1838360d29d86b789 >> Author: Julien Danjou <[email protected]> >> Date: Mon Oct 5 17:13:29 2009 +0200 > >> client: implements maximized and fullscreen requests with Lua >> >> Signed-off-by: Julien Danjou <[email protected]> > > I don't understand the date on this commit, but I'm guessing it was > committed to another branch in October and merged into master only > sometime in May?
Yeah, you can get the "CommitDate" via: $ git show --format=fuller 38edc5 That one confused me, too, when I first looked into this stuff. :) [..] > For completeness, I'll report the error here: >> W: awesome: luaA_dofunction:108: error while running function [..] >> error: /usr/share/awesome/lib/awful/widget/tasklist.lua:47: attempt to >> concatenate a nil value Yeah, this was already fixed: commit 1615cff82a2d19488f2315fa2a7a2fa7570abb03 Author: Uli Schlachter <[email protected]> Date: Sun May 30 12:37:56 2010 +0200 Tasklist: Add some missing parentheses "a .. b or c" is equivalent to "(a .. b) or c", but we want "a .. (b or c)". This bug caused an "attempted to concatenate a nil value" error message. > Following Uli's suggestion, I added a size_hints_honor line to my rc.lua file: > >> client.add_signal("manage", function (c, startup) >> ... stuff ... >> c.size_hints_honor = false >> end) > > and then restarted awesome. But the buggy fullscreening behavior > remains. Even for new clients created after restarting awesome. > > Here's the result of xprop on such a new client [..] Thanks, but sadly the output looks boring. :( > > My config isn't super-elaborate, but it does have a bunch of includes > including some bits of my personal lua libraries. I doubt any of you want to > trace through all of that. So I'll pass this info on in the hopes it > might help. If you still need me to find a minimal change to the default > config which produces the problem, I'll try to track that down when I > have some free minutes. Hm... I could throw some more wild guesses at this. ;) You are only having a single screen? If there are more than one, do they have the same size? Perhaps awesome is confused about what the actual screen size is (but I'd have expected more problems from that)... For a quick test: $ echo 'local ret = "" ; for s = 1, screen.count() do ret = ret .. "\nscreen " .. s .. ":\n" ; for k, v in pairs(screen[s].geometry) do ret = ret .. " " .. tostring(k) .. " " .. tostring(v) end end ; return ret' | awesome-client If there is something wrong from the screen size: Since commit 8c87b7cb57953a4da7abb7bc623880c046f19d6e, awesome gets the geometry from RandR instead of Xinerama. You could check if switching back to Xinerama fixed this problem. For that change in screen.c, line 81: if(xcb_get_extension_data(globalconf.connection, &xcb_randr_id)->present) into e.g. a plain old "if (0)" (The else branch contains the old, xinerama-based code). Also, which size is the trying-to-be-fullscreen terminal and how far off of the screen size is it? (xwininfo in a terminal and clicking on the window gets you accurate size information) Now I can't come up with any more wild guesses. Perhaps something in there is helpful? - -- - - Buck, when, exactly, did you lose your mind? - - Three months ago. I woke up one morning married to a pineapple. An ugly pineapple... But I loved her! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAEBCAAGBQJMGkmiAAoJECLkKOvLj8sGTy0IAKcCf6GMBhRBq4r+i/l91vN5 3YL85Wq1i+AIn5e2+H4XRBp7RrJtkQ9hBIuroXdOk4fE67yXiQ3VrRK3Ph9PTU2B bUFUCu2UsstzbUCVJ8VAdXCKhXS6eL2HvAf48miY4QW59d51qtaYV/ESA449wFLD JzenQ6BM8bbWdEYdvGnld8dFdF9I1qZI3vw1qEF0Cbuehw/WaHUE+kuOC7t+0feP DbVVVxguQMCPn13g/gk658SB7+hQg5QMosmyXDF1C0ZJZtvvlV2Ll2g1RKbBmlhg CLBXYYkXz4OV4R5u1V5NB1GS25k4FlbqeeZIbOzKQnzIgxB4K6mU2mzDLd0lsco= =e4GA -----END PGP SIGNATURE----- -- To unsubscribe, send mail to [email protected].
