Evening, On 15.02.2012 00:43, Alexander Yakushev wrote: > I suppose I did everything I could to prepare the Menubar widget for > submitting to awesome-git. Now I want to ask in what form I have to send > the patch: > - Should it be a simple lua independent module or should I send the diff > from the current git version with my files inside and .lua.in extensions?
Everything should be submitted as git-formatted patch. If I have to do more than 'git am -s [list of files]', then you did it wrong. :-P So commit your stuff to a git checkout near you. Then run 'git format-patch origin/master..' and send the resulting .patch files to this mailing list. > - If the second one is correct, where should I put this module? There is > more than one file in the module, so it requires its own directory. But > it is based on awful's common.list_update and awful.prompt, so it could > alternatively become an awful widget. Depends on how much this looks like a widget. :-) The patches don't have to be perfect the first time you submit them. Few people have managed to make me not complain on the first attempt of submitting something large-ish. :-) So let's just plan several rounds of "Wouldn't it be better if..." and pick what you consider right on the first one. > BUT it actually uses modified > awful.prompt and I'm not sure it is a good thing to accept modifications > to prompt.lua just because of one widget. Depends on how useful those modifications are. Perhaps others want them, too? (I am already curious as to why you need to patch prompt for this...) Cheers, Uli -- - Captain, I think I should tell you I've never actually landed a starship before. - That's all right, Lieutenant, neither have I. -- To unsubscribe, send mail to [email protected].
