Hi,
On 05.05.2012 00:21, Ignas Anikevicius wrote:
> I did some enhancements over the previous patchset. This now grew into 5
> patches :p. Every patch is based on current git/master, so it should
> apply well. They have lengthy commit messages, which should explain
> everything.
>
> Hope it is good now.
Patches 1 & 2 are merged.
Patch 3:
+ table.insert(shownitems, { name = "Run query: " .. query, cmdline = query,
icon = nil })
Why "Run query: gimp"? I find the term "query" here a little confusing. What
would you think about just "Run: gimp"?
Patch 4:
Would merge, but merging this without patch 3 is bad. Also, I call hack for
injecting the terminal prefix, but whatever. Leave this patch as-is.
Could you write a new patch which adds some luadoc which explains the
usage/keybindings?
Patch 5:
- awful.prompt.run({ prompt = "Run app: " },
+ awful.prompt.run({ prompt = ": " },
Uhm, is this silently changing the prompt? Why ": "?
Cheers,
Uli
--
- He made himself, me nothing, you nothing out of the dust
- Er machte sich mir nichts, dir nichts aus dem Staub
--
To unsubscribe, send mail to [email protected].
