On Wed, May 9, 2012 at 8:47 PM, Uli Schlachter <[email protected]> wrote:
> On 07.05.2012 07:06, Anurag Priyam wrote:
>> On Mon, May 7, 2012 at 2:56 AM, Ignas Anikevicius <[email protected]> 
>> wrote:
>>>>> Patch6 should add some documentation to menubar, but I am not familiar
>>>>>        with luadoc, so it somehow does not work.
>>>
>>> Does anybody know how to add a module description with luadoc? I
>>> basically want to have text between the module name and the author box.
>>
>> Fixed in the attached patch.  For future reference, see luadoc for 
>> awful.rules.
>
> I think that this is the last patch from this thread that I should be merging.
> However:
>
> $ git am -s /tmp/0006-Menubar-document-keybindings-and-some-minor-fixes.patch
>  * Running commit-msg hook
> warn: Summary is a bit long. (51 characters)
> Applying: Menubar: document keybindings and some minor fixes
> error: patch failed: lib/menubar/init.lua.in:22
> error: lib/menubar/init.lua.in: patch does not apply
> Patch failed at 0001 Menubar: document keybindings and some minor fixes
> When you have resolved this problem run "git am --resolved".
> If you would prefer to skip this patch, instead run "git am --skip".
> To restore the original branch and stop patching run "git am --abort".
>
> Cheers,
> Uli
>
> (no, I don't feel like fixing that up myself right now)

Hmm, it's not some conflict that I can resolve.  Git just refuses to
apply the patch.  Don't know why.

Also:

--- Generate a pattern matching expression that ignores case.
+--- Generate a pattern matching expression that ignores case.
 -- @param s Original pattern matching expresion.
 local function nocase (s)

I am not sure it is a good idea to expose local functions via luadoc.
It is repeated throughout in the patch.

Its perhaps best to simply recreate the patch documenting the keybindings only.

-- 
Anurag Priyam

--
To unsubscribe, send mail to [email protected].

Reply via email to