On 6 May 2012 13:35, Ignas Anikevicius <[email protected]> wrote:
> Hello everybody,
>
> I've sent these patches to Uli, but forgot to CC the list with my new
> set of patches. Sorry. Here is the new batch.
>
> Patch3 Add a visible selection to exec the query only if there are other
>        selections.
> Patch4 should fix the Bug #993 as well.

this only "fixes" the bug because you removed the 'return' from
'return perform_action(shownitems[current_item])' :P

perform_action should return false instead of true in case it found a
command to execute, since awful.prompt handles hiding and executing
commands on its own.

i attached a patch that shows better what i mean :)

> Patch5 largely the same as before..
> Patch6 should add some documentation to menubar, but I am not familiar
>        with luadoc, so it somehow does not work.
> Patch7 is just an aesthetic change, which brings more order.. :)
>
> All these patches work on my machine, so should work on yours as well.
>
> Cheers,
> Ignas A.

-- dodo

@ignas, sorry for the spam :P

Attachment: 0008-Menubar-use-awful.prompt-proper-api-to-perform-an-ac.patch
Description: Binary data

Reply via email to