On 6 May 2012 19:47, Alexander Yakushev <[email protected]> wrote: > On 05/06/2012 08:36 PM, Uli Schlachter wrote: >> >> Since the bug was reported before then, this can't be due to the two >> commits >> that I just pushed (1730d4f1ea0b85 "Menubar: Add shell completion to >> menubar" >> and b246e87b1acb84 "Menubar: 'Exec: ' item addition to the end"). >> >> Yesterday we had: >> >> - d121d943660 Menubar: Match for command names as well. >> This only touches the code generating the list of suggestions, so >> shouldn't >> be the reason. >> - 6809f6afcf566668 Menubar: Cleanup the environment grabbing >> Nah >> - 390136941071a no keygrabber in menubar needed >> Now we are reaching some old stuff. However, this could have hidden this >> problem earlier? Someone else's keygrabber was stopped here which is no >> longer possible now. > > Ignas' menubar commits doesn't seem to relate with this bug. I still have a > feeling that it is because of dodo's keygrabber commits. Menubar exploits > awful.prompt in kind of dirty way, so I should take a look myself. Sadly not > today, but tomorrow I promise to do it.
i guess, it's my fault :P before awful.keygrabber awful.menubar used to stop the keygrabber by itself. because of the fact that there could be only one keygrabber, this kinda worked. now with awful.keygrabber, which is, in the case of the menubar, handled by awful.prompt, the part where the keygrabber is stopped doesn't get invoked, because perform_action isn't returning false for key == "Enter". this is what patch 0008 fixes. >> I bet it will be something stupid. Like me breaking setslave() by >> forgetting a "c." > > How about creating a feature request like "Port Awesome to Wayland and > replace Metro on W8" or "Change scripting language from Lua to PHP"? > > -- dodo sorry for the lazy testing -- To unsubscribe, send mail to [email protected].
