On 4/11/2012 11:21 PM, Anthony Petrov wrote:
Hi Omair and Artem,
On 4/11/2012 9:20 PM, Omair Majid wrote:
PS. Perhaps it also makes sense to rewrite that comment in the
XDecoratedPeer to replace the word "bug" with something saying that this
is implemented according to the ICCCM specification with a reference to
the paragraph 4.1.5 of it?
Agreed. I would like to go so far as to make this the default, and add
other window managers (which are deviating from ICCCM) as exceptions. I
am afraid of introducing regressions, though.
I wholeheartedly support this idea in theory. But it seems scary in
practice. We would need to run all automatic and manual AWT regression
tests on at least all major WMs (Metacity, Kwin, Compiz, and (sic!) CDE
- as long as we support Solaris CDE desktops, not sure if this is
relevant to JDK 8 though) to ensure no regressions arise. Note that we
have to test this with quite old versions of the WMs, e.g. Metacity from
Gnome 2.6 (or is it 2.4?) - this is what Solaris 10 has to offer, etc.
And ideally we would also want to test on all those forgotten/rare
creatures like SawFish, Motif, Enlightenment, etc. This looks like a lot
of work for such a simple fix.
However, your current fix looks pretty safe and is fully consistent with
our current XAWT code.
Artem, what's your opinion?
Sorry for such a long delay from my side...
Mario absolutely correctly wrote in his email:
To be honest, I'm not that happy with the fix, but not because of
Omair's patch, which is very fine given the current state of things,
but because we keep adding this to each and every new WM we find,
although fixing AWT in this regard will be probably more work than
adding another exception to the list and an issue for perennial
backward compatibility...
and I feel exactly the same: the fix is fine, but the current AWT
approach to workaround WM bugs isn't. Please, consider this as my
approval :)
Thanks,
Artem
--
best regards,
Anthony
