Hello,

as I can see there is a memory leak in case when the index is greater than or equal to num_syms:

837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, &num_syms);
838 if (index >= num_syms) {
839 return NoSymbol;
840 }

key_syms is not freed.

--
Thanks,
Alexander.


On 10/4/16 1:06 PM, Alan Burlison wrote:
On 03/10/2016 22:08, Phil Race wrote:

Do we have a 2nd reviewer yet ? I have not seen it.

Gah you are right, I thought I'd seen a 2nd. Any takers?


Reply via email to