Thank you Denis and Sergey for the review.
-Shashi From: Denis Fokin [mailto:denis.fo...@gmail.com] Sent: Friday, April 13, 2018 3:58 PM To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com> Cc: Sergey Bylokhov <sergey.bylok...@oracle.com>; Hendrik Schreiber <h...@tagtraum.com>; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> [11] JDK-8181910: [macos] Support dark title bars on macOS Hi Shashi, Thank you for the fix, it looks fine. Thank you, Denis. On Thu, Apr 12, 2018 at 7:30 AM Shashidhara Veerabhadraiah <HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"shashidhara.veerabhadra...@oracle.com> wrote: Thank you Sergey for the review. Denis, Please let me know if you have any comments on the changes. Thanks and regards, Shashi -----Original Message----- From: Sergey Bylokhov Sent: Thursday, April 12, 2018 3:36 AM To: Denis Fokin <HYPERLINK "mailto:denis.fo...@gmail.com"denis.fo...@gmail.com> Cc: Hendrik Schreiber <HYPERLINK "mailto:h...@tagtraum.com"h...@tagtraum.com>; Shashidhara Veerabhadraiah <HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"shashidhara.veerabhadra...@oracle.com>; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: Re: <AWT Dev> [11] JDK-8181910: [macos] Support dark title bars on macOS Thank you, the fix looks fine. On 11/04/2018 07:44, Denis Fokin wrote: > Hi Sergey, > > can I just approve any modifications and usage of the patch? I am > absolutely ok with pushing or improving the fix by Shashidhara. > > __ > Thank you, > Denis > > On Tue, Apr 3, 2018 at 10:50 PM Sergey Bylokhov > <HYPERLINK "mailto:sergey.bylok...@oracle.com"sergey.bylok...@oracle.com > <mailto:HYPERLINK > "mailto:sergey.bylok...@oracle.com"sergey.bylok...@oracle.com>> wrote: > > Yes, this fix can be contributed by someone from the JB. > > On 03/04/2018 06:48, Hendrik Schreiber wrote: > > Hey, > > > > I was wondering how this is going. Are you guys still stuck, > waiting for Denis to help out? > > > > -hendrik > > > > > >> On Mar 30, 2018, at 07:32, HYPERLINK >"mailto:shashidhara.veerabhadra...@oracle.com"shashidhara.veerabhadra...@oracle.com > <mailto:HYPERLINK >"mailto:shashidhara.veerabhadra...@oracle.com"shashidhara.veerabhadra...@oracle.com> > wrote: > >> > >> Sure. I did had a confusion to put for review though but did not > know what to do and felt not to keep waiting. Thanks for the > direction Sergey. > >> > >> Thanks and regards, > >> Shashi > >> > >> > >> On 29/03/18 7:45 PM, Sergey Bylokhov wrote: > >>> Unfortunately we cannot accept the patch which were suggested > in the description of the bug. Initially it was implemented in > JetBrains JRE. We can accept it if someone from the JetBrains will > contribute it. > >>> > >>> Maybe Denis who is author of the fix can help? > >>> > >>> On 28/03/2018 02:29, Shashidhara Veerabhadraiah wrote: > >>>> Hi All, Please review an enhancement for the below bug: > >>>> > >>>> Enhancement: https://bugs.openjdk.java.net/browse/JDK-8181910 > >>>> > >>>> Webrev: > http://cr.openjdk.java.net/~sveerabhadra/8181910/webrev.00/ > >>>> > >>>> This utilizes the NSAppearance to set the appearance theme to > dark or light. > >>>> > >>>> Thanks and regards, > >>>> > >>>> Shashi > >>>> > >>> > >>> > >> > > > > > -- > Best regards, Sergey. > -- Best regards, Sergey.
