On Fri, 6 Aug 2021 15:17:48 GMT, lawrence.andrews 
<github.com+87324768+lawrence-and...@openjdk.org> wrote:

>> 1) This testcase was throwing error saying Error: Not a test or directory 
>> containing tests: java/awt/print/PrinterJob/XparColor.java
>> 2) Added @test tag so that this testcase can be run
>> 3) Since Applet is deprecated and its not supported any more in the future 
>> release remove applet and make the testcase to run as main
>> 4) Since this is a manual testcase instruction frame or dailog was not 
>> visible just print dialog was visible so fixed it.
>> 5) When the testcase was run via main method two print dialog was shown one 
>> was from main method and one more was from constructor. Fixed to show just 
>> one print dialog.
>> 6) Since JDK 17 introduce metal rendering touching the java2d code thought 
>> this testcase will be useful to checking the rendering. 
>> 
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fixed jcheck issue

test/jdk/java/awt/print/PrinterJob/XparColor.java line 157:

> 155:             throw new RuntimeException("Timed out after " + sleepTime / 
> 1000 + " seconds");
> 156:         } catch (InterruptedException e) {
> 157:             if (!testGeneratedInterrupt) throw e;

I guess timeout code is there here but for somehow it is not working as 
expected..Could you check?
Otherwise there are other ways of handling user interaction done in
java/awt/print/PrinterJob/BannerTest.java
java/awt/print/PrinterJob/TestSaveFileWithoutPrinter.java

-------------

PR: https://git.openjdk.java.net/jdk/pull/4769

Reply via email to