On Thu, 12 Aug 2021 11:59:14 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> lawrence.andrews has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fixed test instruction and execute the testcase on metal only for mac
>
> test/jdk/java/awt/print/PrinterJob/XparColor.java line 134:
> 
>> 132:     private static void createAndShowTestDialog() {
>> 133:         String testInstruction = "This testcase will be launched twice 
>> on mac platform and once on non mac platform.\n" +
>> 134:                 "On Mac once with default pipeline and once again with 
>> Metal pipeline.\n" +
> 
> I think it will be better to rephrase this line with "This test will be run 
> with default pipeline in all OS and additionally with metal pipeline only in 
> macOS"

although I am not sure why it is important to run in metal pipeline. I don't 
think metal has any effect on printing par se.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4769

Reply via email to