On Wed, 11 Aug 2021 15:35:43 GMT, lawrence.andrews
<github.com+87324768+lawrence-and...@openjdk.org> wrote:
>> 1) This testcase was throwing error saying Error: Not a test or directory
>> containing tests: java/awt/print/PrinterJob/XparColor.java
>> 2) Added @test tag so that this testcase can be run
>> 3) Since Applet is deprecated and its not supported any more in the future
>> release remove applet and make the testcase to run as main
>> 4) Since this is a manual testcase instruction frame or dailog was not
>> visible just print dialog was visible so fixed it.
>> 5) When the testcase was run via main method two print dialog was shown one
>> was from main method and one more was from constructor. Fixed to show just
>> one print dialog.
>> 6) Since JDK 17 introduce metal rendering touching the java2d code thought
>> this testcase will be useful to checking the rendering.
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Rewrote the code for better starting the test and timeout
test/jdk/java/awt/print/PrinterJob/XparColor.java line 122:
> 120:
> 121: private static void createAndShowTestDialog() {
> 122: String testInstruction = "This testcase will be launched twice,
> once for opengl and once for metal.\n" +
The test is supposed to be run in all platforms, not only in mac. Since the
default pipeline is not opengl in non-mac platform and also metal is not
supported in non-mac platform, so this test instruction that it will run in
opengl and metal is wrong in non-mac platform.
You probably need to modify to say it will be run in default pipeline for a
particular platform and metal and subsequently check if the platform is non-mac
and bail out if metal=true system property is set and inform user that metal
cannot be run in present non-mac platform
-------------
PR: https://git.openjdk.java.net/jdk/pull/4769
