On 06/28/2012 05:52 PM, Rafał Miłecki wrote: > 2012/6/10 Hauke Mehrtens <ha...@hauke-m.de>: >> On 06/10/2012 06:54 PM, Rafał Miłecki wrote: >>> 2012/6/6 Florian Fainelli <flor...@openwrt.org>: >>>> Hi Hauke, >>>> >>>> On Tuesday 05 June 2012 23:55:05 Hauke Mehrtens wrote: >>>>> The SoCs do not need any special handling in bcma_pmu_pll_init(), >>>>> bcma_pmu_resources_init(), bcma_pmu_swreg_init() and >>>>> bcma_pmu_workarounds. This patches suppresses some warnings in the log. >>>> >>>> This does not look like it scales very good, how about you turn the >>>> pr_err() >>>> into a pr_debug() so that developpers porting bcma on a new chip need to >>>> turn >>>> on the appropriate debug knobs to get the message? >>> >>> debug sounds fine for me >>> >> Hi Rafał, >> >> bcma_pmu_swreg_init() and bcma_pmu_pll_init() are doing nothing should >> they get removed? In the current version of the patch I also removed the >> chip ids of the PCIe based cards from the switch case statement if they >> just ended in a break, is that ok with you? > > Original si_pmu_pll_init had some meaning for BCM4329, BCM4319, > BCM4336 and BCM4330. I guess all of them are fullmac devices, right? > > Original si_pmu_swreg_init got meaning for BCM4336 and BCM4336. > > Seems both can be dropped? > I also check it with the BSD licensed code I have here and these functions are only containing code for fullmac chips as I see.
I am for dropping them. Hauke _______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev
