Hello,
I've now taken a look at these patches and though they might be going in the
right direction, I cannot consider them for inclusion in version 1.40 for
several reasons:
1. They are not relative to the current CVS.
2. They are a significant change from the current code, which is not a problem
during the development cycle, but *is* a major problem at this point.
3. They seem to change non-FreeBSD code -- perhaps not the functionality but
by adding a switch().
On the other hand, I would suggest that you work with Jeremy Reed as his patch
once it is appropriately tweaked is something that I could see adding to 1.40
because:
1. It is relative to the CVS
2. It makes the mininum necessary changes
3. For the most part the changes seem to be FreeBSD specific
His patch only addresses one of the two problems mentioned, so perhaps there
is more work to be done.
Regards,
Kern
On Wednesday 13 December 2006 07:54, Oliver Lehmann wrote:
> Kern Sibbald wrote:
>
> > Please fix it up correctly, then send it to me in the same diff format
versus
> > the current CVS, but please send it as an attachment to avoid the
possibility
> > of word wrap. I'll then take a look at putting it in the code. If you
send
> > it in the next few days, it will probably become part of 1.40.0 ...
>
> I've attached 2 patches (will both apply with some offset)
>
> patch-src-findlib-create_file.c
> Try to unset file flags of the sourcefile when the hardlink failed.
> Retry to hardlink then. If the hardlink fails then again, restore the
> file flags of the sourcefile. If the hardlink was created w/o errors,
> restore the fileflags of the sourcefile.
>
> patch-src-findlib-attribs.c
> when restoring a symlink, use lchflags to restore the file flags
> defined for the symlink ("new feature")
> when restoring a hardlink, don't call chmod, chown, utime because it is
> a hardlink and don't have such attributes (as far as I know, if someone
> with more FS-foo can step up and confirm this?). Changing this
> attributes will change the sourcefiles attributes which is probably not
> what is wanted here anyway....
>
>
> --
> Oliver Lehmann
> http://www.pofo.de/
> http://wishlist.ans-netz.de/
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users
