On Tue, 2010-11-16 at 10:55 +0530, Madhavan S wrote: > Recently, I have created a PHP script for an automation process (CRON) > followed by the OOPs concept which I attached with this mail. Please > find and take a look.
Thanks for the sample code Madhavan! I've had a quick look at it, and it raised a few questions. Hope you won't mind! : ) - How often do you develop using OO, compared to procedural programming? How would you rate your understanding of OO programming? - Could you provide some context on the application on which this code was used? What problem were you trying to solve when you wrote that code? - Why did you choose this structure for your classes? Can you elaborate a bit? - In fileSystemHandler->getFlatFile(), how do you handle the case where there is no file in FLAT_FILE_DIR? Also, why do you only read 512 bytes in this file, in fileSystemHandler->readData()? - If the connexion to the db in farSidesGateway->__construct() fails, why don't you stop the execution of the script? - What would you change to your code if these objects were used in a program that also connects independently to a mysql database? - Why did you chose to put things such as $this->cd_asn_reference_number directly on the DBSystemHandler class, instead of creating a specific class to describe services ? - Why didn't you include comments on your code? - What would you want to improve or change to this sample code? - Are there any areas where you would like to improve your skills? Thanks! Xavier. _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
