Add code to verify that update handler specified with either -t or of
-d exists before commencing the update procedure.

Signed-off-by: Andrey Smirnov <[email protected]>
---
 commands/barebox-update.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/commands/barebox-update.c b/commands/barebox-update.c
index 84798ab0d..f76aa19a5 100644
--- a/commands/barebox-update.c
+++ b/commands/barebox-update.c
@@ -24,6 +24,12 @@
 #include <bbu.h>
 #include <fs.h>
 
+static void print_handlers_list(void)
+{
+       printf("registered update handlers:\n");
+       bbu_handlers_list();
+}
+
 static int do_barebox_update(int argc, char *argv[])
 {
        int opt, ret, repair = 0;
@@ -46,8 +52,7 @@ static int do_barebox_update(int argc, char *argv[])
                        data.flags |= BBU_FLAG_YES;
                        break;
                case 'l':
-                       printf("registered update handlers:\n");
-                       bbu_handlers_list();
+                       print_handlers_list();
                        return 0;
                case 'r':
                        repair = 1;
@@ -57,6 +62,12 @@ static int do_barebox_update(int argc, char *argv[])
                }
        }
 
+       if (!barebox_update_handler_exists(&data)) {
+               printf("handler '%s' does not exist\n", data.handler_name);
+               print_handlers_list();
+               return COMMAND_ERROR;
+       }
+
        if (argc - optind > 0) {
                data.imagefile = argv[optind];
 
-- 
2.17.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Reply via email to