On Sat, Nov 10, 2018 at 08:59:52AM +0100, Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel <[email protected]> > --- > drivers/video/ssd1307fb.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/ssd1307fb.c b/drivers/video/ssd1307fb.c > index d68f0c505..1fd1a3cfb 100644 > --- a/drivers/video/ssd1307fb.c > +++ b/drivers/video/ssd1307fb.c > @@ -548,8 +548,11 @@ static int ssd1307fb_probe(struct device_d *dev) > /* clear display */ > array = ssd1307fb_alloc_array(par->width * par->height / 8, > SSD1307FB_DATA); > - if (!array) > - return -ENOMEM; > + if (!array) { > + dev_err(&client->dev, "Couldn't not allocate an array\n");
Please do not add messages in allocation failure pathes. When we get out of memory it's not really interesting where it happened, at least not when it's not the culprit itself. It would rather be interesting who ate all your memory before. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
