Hi Sascha,
On 19-08-05 12:17, Sascha Hauer wrote:
> Hi Marco,
>
> On Fri, Jul 26, 2019 at 11:34:00AM +0200, Marco Felsch wrote:
> > Since commit 51061a9884a3 ("mtd: nand: nand_mxs: Add subpage read
> > support") the ecc_read_page and ecc_write_page page_size can be differ
> > if the calculation is not writesize+oobsize. So during write more bytes
> > are passed trough the bch than during the read operation.
> >
> > It seems that there are no problems for typical nand flashes using the
> > "normal" layout e.g. 2048+64 (user+oob) but if it gets a bit atypical
> > e.g. 2048+128 (user+oob) this leads into ecc errors.
>
> What problems did you see exactly? I am using boards here with 2k/128b
> page size and they seem to work properly, also when interacting with Linux.
You are right, the problem was caused by a kernel bug.. which is fixed
now.
Anyway IMHO it seems to be right to write as many bytes as are read. So
do you will accept the patches if I adapt the commit message(s).
Regards,
Marco
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
