On Mon, Sep 03, 2007 at 12:33:40PM -0400, Simon Ruggier wrote: > Here, test this out - everything should work the same, except that > there are --enable-gui and --enable-opensync flags that will configure > those directories and include them in all the recursive targets. I > also fixed all the Makefiles so that make dist generates a tarball > similar to the release ones, and got out of source tree builds to > work.
Thanks for the patch! I've taken a look at it, and there are a couple things I'm not keen on. If you send me a patch that addresses these issues, I'll probably apply it. :-) You've fixed a number of configure problems and made it more robust, which is great. First, in the debian/rules makefile, you changed: - $(MAKE) distclean - (cd gui && $(MAKE) distclean) + -$(MAKE) distclean + -(cd gui && $(MAKE) distclean) I'd rather fix the cause of the make errors than ignore them. Why did you need the - prefixes? Second, the --enable-opensync switch doesn't work for me. I had to use --enable-opensync-plugin which was different from the --help output. Third, if you're adding a build dependency to the debian scripts for libopensync-dev, I'd like it to match version 0.22 or greater. What system are you testing this on, btw? > There are two things I'm not happy with: I had to put a set of > variable exports in configure.ac when a subdirectory is enabled, so > that they build and link against the source tree - I couldn't find a > more elegant way to get that behaviour. I'm not sure either, but I suspect the answer might be in other projects that have a library portion to them. The tools/ and examples/ subdirectories use autoconf to manage this, but they are part of the configure system. I don't mind the exports, as similar things are required in the debian and rpm builds. > The other thing is that when > the subdirectories aren't enabled (and they aren't by default), they > won't be included in make dist. I figure this is ok since you don't > use make dist to generate your release tarballs anyway, but I added a > check that will warn prominently when the conditionally enabled > subdirectories are missing from the dist. According to the > documentation, the only other workaround is to manually include them > in the dist instead of echoing a warning. A hard failure would be better, along with the warning. Something that stops the build process, so that it never accidentally gets run in some automated build process. Thanks! - Chris ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
