On 9/5/07, Chris Frey <[EMAIL PROTECTED]> wrote: > On Tue, Sep 04, 2007 at 10:01:41PM -0400, Simon Ruggier wrote: > > Ok, I've fixed the inaccurate help string, removed the extra build > > dep, and made the make dist warning into an error :) > > Patch applied, thanks! > > This change introduced something that I didn't notice the first time: > > --- src/Makefile.am 18 Aug 2007 05:06:06 -0000 1.23 > +++ src/Makefile.am 5 Sep 2007 21:07:52 -0000 > @@ -25,9 +25,9 @@ > # Only ever increment the first 2 numbers in this version: > LIB_BARRY_VERSION = 0:9:0 > > -# Disable the default -I. -I$(srcdir) -I$(topdir), etc, as our includes > -# are proper anyway. :-) > -DEFAULT_INCLUDES = > +# Disable the default -I. -I$(srcdir) -I$(topdir), etc, but $(top_builddir) > is > +# needed for config.h > +DEFAULT_INCLUDES = -I$(top_builddir) > > > Since the gui build is now part of the main build (or can be), this > removes one of the built-in checks I had, which always built the GUI > based on a "make install" of the root directory. Thus, any bugs in > the headers that would prevent a proper build (e.g. including config.h > in a published header, or forgetting to install one) would be > shown by the GUI build. > > I think the only way around this is to make sure the maintainer/ > scripts always build in a two-stage manner, although it would be nice > to catch these kinds of bugs as soon as possible. > > If you have any suggestions on how to keep this automatic header > checking, I'm all ears. :-)
If you build the gui as a standalone package, in a script perhaps, you should still be able to build it with no extra -I flags. The above change only affects the build of the main library (specifically, the src directory), and the flags that are exported in the configure script don't get applied when the gui package is built by itself. Another possible solution may be to maintain an explicit list of files you expect to be installed, and use a script to check that they're present on the system and in the packages. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
