On Tuesday 13 June 2006 22:38, VMiklos wrote: > hi > > i've made a little patch to fwcutter's Makefile to install the > manpage, too and respect the user's cflags:
Modifying CFLAGS is one of the most stupid things people are doing. Except from adding -Os on small systems perhaps. But virtually nobody has got such a small system. The people having these know how to modify makefiles. ;) You also lost the -std=c99 If we want to make CFLAGS and PREFIX overridable, do we also want CC to be overridable? (Crosscompiling). What about LDFLAGS? What is special about it? In my opinion none of these should be overridable from outside of the Makefile. They are in the top of the Makefile, so they can easily be found and modified, if really needed. And next time, please inline patches into the mail. -- Greetings Michael. _______________________________________________ Bcm43xx-dev mailing list [email protected] http://lists.berlios.de/mailman/listinfo/bcm43xx-dev
