On Wednesday 14 June 2006 16:24, Erik Mouw wrote: > On Wed, Jun 14, 2006 at 03:58:40PM +0200, Michael Buesch wrote: > > On Tuesday 13 June 2006 22:38, VMiklos wrote: > > > hi > > > > > > i've made a little patch to fwcutter's Makefile to install the > > > manpage, too and respect the user's cflags: > > > > Modifying CFLAGS is one of the most stupid things people > > are doing. Except from adding -Os on small systems perhaps. > > But virtually nobody has got such a small system. The people > > having these know how to modify makefiles. ;) > > > > You also lost the -std=c99 > > > > If we want to make CFLAGS and PREFIX overridable, do we > > also want CC to be overridable? (Crosscompiling). > > What about LDFLAGS? What is special about it? > > It does make sense for cross compiling, but then again: you could as > well "cut" the firmware on the host system.
Yeah, but then CC must also be overridable (as I wrote). > > In my opinion none of these should be overridable from > > outside of the Makefile. They are in the top of the Makefile, > > so they can easily be found and modified, if really needed. > > Hey, if somebody wants to use "optimal" compiler flags to squeeze the > last bit of performance out of the run-once tool "fwcutter", let him do > so ;-) Sure. We add so many CFLAGS that it takes 2 seconds longer to compile it, to gain 1msec afterwards when running the tool. Looks sane to me :D -- Greetings Michael. _______________________________________________ Bcm43xx-dev mailing list [email protected] http://lists.berlios.de/mailman/listinfo/bcm43xx-dev
