On Wed, Jun 14, 2006 at 03:58:40PM +0200, Michael Buesch wrote: > On Tuesday 13 June 2006 22:38, VMiklos wrote: > > hi > > > > i've made a little patch to fwcutter's Makefile to install the > > manpage, too and respect the user's cflags: > > Modifying CFLAGS is one of the most stupid things people > are doing. Except from adding -Os on small systems perhaps. > But virtually nobody has got such a small system. The people > having these know how to modify makefiles. ;) > > You also lost the -std=c99 > > If we want to make CFLAGS and PREFIX overridable, do we > also want CC to be overridable? (Crosscompiling). > What about LDFLAGS? What is special about it?
It does make sense for cross compiling, but then again: you could as well "cut" the firmware on the host system. > In my opinion none of these should be overridable from > outside of the Makefile. They are in the top of the Makefile, > so they can easily be found and modified, if really needed. Hey, if somebody wants to use "optimal" compiler flags to squeeze the last bit of performance out of the run-once tool "fwcutter", let him do so ;-) Erik -- +-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 -- | Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands _______________________________________________ Bcm43xx-dev mailing list [email protected] http://lists.berlios.de/mailman/listinfo/bcm43xx-dev
