Pavel Roskin wrote: Thanks for the feedback. I knew it wasn't ready, but I appreciate your comments. > > Just a quick feedback on that package. > > Please don't include Module.symvers, your version is not useful for > anyone else. It will be generated is needed.
Done. > I'm getting a compile error: > /home/proski/src/bcm43xx-softmac-sa/bcm43xx/bcm43xx.h:896:3: error: > #error "Using neither DMA nor PIO? Confused..." > > I think the best solution would be to define both > CONFIG_BCM43XX_DMA and CONFIG_BCM43XX_PIO. You make want to make it > configurable, but then don't compile bcm43xx_pio.c and bcm43xx_dma.c > unconditionally. I made PIO to be conditional and fixed it for conditional compilation of bcm43xx_pio.c. DMA mode is always turned on. > The debugfs requirement seems to defeat the whole purpose of the > standalone distribution. It is conditional and now turned off. > BCM43xx_NR_LOGGED_XMITSTATUS is defined only if CONFIG_BCM43XX_DEBUG is > defined, but bcm43xx_debugfs.c uses it unconditionally. That was a type in the makefile. > There may be more compile problems, but I gave up at this point. > > Speaking of the build system, you may want to have a warning in case if > anything that is compiled as a module (either bcm43xx or softmac) is > already available and linked into the kernel. Make sure the checks > don't affect "make clean" and similar maintenance commands. I'm not sure how to do this, but will do some more investigation. There is a new version on the FTP site. I would appreciate seeing if that will work for you. Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
