Johannes Berg wrote:
> On Wed, 2007-08-15 at 10:24 -0500, Larry Finger wrote:
>
>> MODALIAS=ssb:v4243id0812rev0a
>
> Oh. I see. Somewhere case got confused, the modalias is this:
>
> alias: ssb:v4243id0812rev0A*
>
> Apparently we have to use %.2X and not %.2x in the uevent generation
> code. Michael, want a patch or can you just fix it?
This patch did not fix the problem:
Index: wireless-dev/drivers/ssb/main.c
===================================================================
--- wireless-dev.orig/drivers/ssb/main.c
+++ wireless-dev/drivers/ssb/main.c
@@ -331,7 +331,7 @@ static int ssb_device_uevent(struct devi
ret = add_uevent_var(envp, num_envp, &i,
buffer, buffer_size, &length,
- "MODALIAS=ssb:v%.4xid%.4xrev%.2x",
+ "MODALIAS=ssb:v%.4xid%.4xrev%.2X",
ssb_dev->id.vendor, ssb_dev->id.coreid,
ssb_dev->id.revision);
envp[i] = NULL;
With this patch, the output of udevmonitor --env now is:
UEVENT[1187193083.069367] add@/module/ssb
ACTION=add
DEVPATH=/module/ssb
SUBSYSTEM=module
SEQNUM=1748
UEVENT[1187193083.070838] add@/bus/ssb
ACTION=add
DEVPATH=/bus/ssb
SUBSYSTEM=bus
SEQNUM=1749
UEVENT[1187193083.072529] add@/bus/pci/drivers/b43-pci-bridge
ACTION=add
DEVPATH=/bus/pci/drivers/b43-pci-bridge
SUBSYSTEM=drivers
SEQNUM=1750
UDEV [1187193083.076531] add@/module/ssb
UDEV_LOG=3
ACTION=add
DEVPATH=/module/ssb
SUBSYSTEM=module
SEQNUM=1748
UDEVD_EVENT=1
UDEV [1187193083.080356] add@/bus/ssb
UDEV_LOG=3
ACTION=add
DEVPATH=/bus/ssb
SUBSYSTEM=bus
SEQNUM=1749
UDEVD_EVENT=1
UDEV [1187193083.083627] add@/bus/pci/drivers/b43-pci-bridge
UDEV_LOG=3
ACTION=add
DEVPATH=/bus/pci/drivers/b43-pci-bridge
SUBSYSTEM=drivers
SEQNUM=1750
UDEVD_EVENT=1
UEVENT[1187193083.148865]
add@/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:0
ACTION=add
DEVPATH=/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:0
SUBSYSTEM=ssb
SEQNUM=1751
PHYSDEVBUS=ssb
MODALIAS=ssb:v4243id0812rev0A
UEVENT[1187193083.150987]
add@/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:1
ACTION=add
DEVPATH=/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:1
SUBSYSTEM=ssb
SEQNUM=1752
PHYSDEVBUS=ssb
MODALIAS=ssb:v4243id0817rev03
UDEV [1187193083.156997]
add@/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:1
UDEV_LOG=3
ACTION=add
DEVPATH=/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:1
SUBSYSTEM=ssb
SEQNUM=1752
PHYSDEVBUS=ssb
MODALIAS=ssb:v4243id0817rev03
UDEVD_EVENT=1
UDEV [1187193083.162392]
add@/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:0
UDEV_LOG=3
ACTION=add
DEVPATH=/devices/pci0000:00/0000:00:02.0/0000:01:00.0/ssb0:0
SUBSYSTEM=ssb
SEQNUM=1751
PHYSDEVBUS=ssb
MODALIAS=ssb:v4243id0812rev0A
UDEVD_EVENT=1
Am I correct in assuming that we don't need the PCIe core listed here because
that driver is built
into ssb?
Larry
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
