On 01/06/2010 02:57 PM, Rafał Miłecki wrote: > V2: adjust to renamed function, fill index array > > Signed-off-by: Rafał Miłecki <[email protected]> > --- > drivers/net/wireless/b43/phy_n.c | 81
Just a little nitpick to save John some work, and to keep the patches straight. When you submit a second (or later) version of a patch, indicate the version in the mail header as in [PATCH 2/5 V2] b43:.... The upstream software strips all of that out and the commit header will be clean. In addition, it is useful to state what is different below the --- marker. The software also strips that part of the patch - the permanent commit message should be devoid of the details of the review message. It is like making sausage! Better that the details are hidden. Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
