W dniu 6 stycznia 2010 22:23 użytkownik Larry Finger <[email protected]> napisał: > On 01/06/2010 02:57 PM, Rafał Miłecki wrote: >> V2: adjust to renamed function, fill index array >> >> Signed-off-by: Rafał Miłecki <[email protected]> >> --- >> drivers/net/wireless/b43/phy_n.c | 81 > > Just a little nitpick to save John some work, and to keep the patches > straight. > > When you submit a second (or later) version of a patch, indicate the version > in > the mail header as in [PATCH 2/5 V2] b43:.... The upstream software strips all > of that out and the commit header will be clean. > > In addition, it is useful to state what is different below the --- marker. The > software also strips that part of the patch - the permanent commit message > should be devoid of the details of the review message. It is like making > sausage! Better that the details are hidden.
Uh, so once again I've made some mistake in my submitting. Sorry John, thanks Larry. I can excuse myself only with fact that it's something I've learn from drm guys. Of course I'll change my ways. Ex.: commit 3dfc63922f8edfa8774bf1ba882225c5f91b2220 Author: Alex Deucher <[email protected]> Date: Tue Dec 22 10:06:49 2009 -0500 drm/radeon/kms: add cvt mode if we only have lvds w/h and no edid (v4) This fixes LVDS on some mac laptops without a panel edid. v2 - Set proper mode type flags v3 - Note that this is not neceesarily the exact panel mode, but an approximation based on the cvt formula. For these systems we should ideally read the mode info out of the registers or add a mode table, but this works and is much simpler. v4 - Update comments and debug message. Signed-off-by: Alex Deucher <[email protected]> Signed-off-by: Dave Airlie <[email protected]> -- Rafał _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
