Hi Tom, I'm sorry I'm teasing you again. Unfortunately now it really looks that this is hitting quite close to your backyard. I fixed that particular patch problem (below) manually an as you can guess it did not help fixing whole patching process.
> "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC - NAND driver > updates" > fails in several places. Firs one takes place when appending > > arch/arm/include/asm/arch-am33xx/omap_gpmc.h. > It tries to make following replacement: > - OMAP_ECC_BCH8_CODE_HW+ OMAP_ECC_BCH8_CODE_HW, > > even though that comma was already provided by: > "[U-Boot,v8,1/5] mtd: nand: omap: enable BCH ECC scheme using ELM for generic > platform" > while creating the stuct including that line. > > Next problem hits when: "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC - NAND driver updates" <http://patchwork.ozlabs.org/patch/273769> patch tries to execute following chunk over drivers/mtd/nand/omap_gpmc.c: --------- @@ -295,7 +296,7 @@ static int omap_calculate_ecc(struct mtd_info *mtd, const uint8_t *dat, break; case OMAP_ECC_BCH8_CODE_HW_DETECTION_SW: case OMAP_ECC_BCH8_CODE_HW: - ptr = &gpmc_cfg->bch_result_0_3[0].bch_result_x[3]; + ptr = &gpmc_cfg->bch_result_0_3[0].bch_result3; val = readl(ptr); ecc_code[i++] = (val >> 0) & 0xFF; ptr--; --------- *Well, there is no matching pattern there. Instead, there would be:* --------- break; #ifdef CONFIG_BCH case OMAP_ECC_BCH8_CODE_HW_DETECTION_SW: #endif case OMAP_ECC_BCH8_CODE_HW: ptr = &gpmc_cfg->bch_result_0_3[0].bch_result_x[3]; val = readl(ptr); ecc_code[i++] = (val >> 0) & 0xFF; ptr--; for (j = 0; j < 3; j++) { val = readl(ptr); ecc_code[i++] = (val >> 24) & 0xFF; ecc_code[i++] = (val >> 16) & 0xFF; ecc_code[i++] = (val >> 8) & 0xFF; ecc_code[i++] = (val >> 0) & 0xFF; ptr--; --------- That is pretty much artwork of "[U-Boot,v8,3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes<http://patchwork.ozlabs.org/patch/282206/> " It seems that versions "[U-Boot,v5-v7,3/5] mtd: nand: omap: optimize chip->ecc.calculate() for H/W ECC schemes<http://patchwork.ozlabs.org/patch/282206/>" would satisfy this hunk, but somehow version v7 has been changed so that "[U-Boot,v2,2/3] mtd: nand: omap: add support for BCH16_ECC - NAND driver updates" <http://patchwork.ozlabs.org/patch/273769> is not proper pair with it any more. Would it not be possible using version v6 instead or v7 or are there major fixes found there? Best regards, Matti tiistai, 5. marraskuuta 2013 18.24.52 UTC+2 [email protected] kirjoitti: > > > -- For more options, visit http://beagleboard.org/discuss --- You received this message because you are subscribed to the Google Groups "BeagleBoard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
