JJZolx wrote: 
> Here's part of the problem:
> 
> my $search = Slim::Utils::Text::ignoreCaseArticles($name, 1);
> my $sort   = Slim::Utils::Text::ignoreCaseArticles(($sortedList[$i] ||
> $name));
> 
> The second argument to Slim::Utils::Text::ignoreCaseArticles() tells it
> to transliterate the search string. This isn't being done to the sort
> string. The fix may be as simple as:
> 
> my $sort   = Slim::Utils::Text::ignoreCaseArticles(($sortedList[$i] ||
> $name), 1);
> 
> Just as long as the transliterated strings sort properly (or as
> expected). Apparently the transliteration was added when searching for
> accented characters failed following the adoption of case and
> character-sensitive names.
> 
> http://bugs.slimdevices.com/show_bug.cgi?id=16956
The adding of that transliteration broke the comparison of $sort and
$search and gave rise to the bug I reported here initially.  I have now
posted a proposed fix under bug
http://bugs.slimdevices.com/show_bug.cgi?id=18131 that leaves the
contents of the fields untouched, but when they are compared they are
both in transliterated form (ie without accents).

Further, I have done some initial tests with the proposed fix to
http://bugs.slimdevices.com/show_bug.cgi?id=18096.  All OK so far but
more to do.  Can I very strongly suggest that if we want this in LMS
someone else needs to test it as well?  It's easy to apply the patch if
you are happy modifying code a little.



LMS 7.9 on VortexBox Midi, Xubuntu 14.04, FLACs 16->24 bit,
44.1->192kbps. LMS & Squeeze2upnp to MF M1 CLiC (to MF amp & ESLs) &
Marantz CR603 UPnP renderers.  Minimserver (server) & upplay (control
point) to same renderers & to upmpdcli/mpd PC renderers.  Squeezelite to
Meridian USB Explorer DAC to speakers/phones.  Wireless Xubuntu 14.04
laptop with firefox/upplay or Android 'phone with
Squeeze-Commander/BubbleUPnP controls LMS/Minimserver.   Have a Touch
with EDO, and a spare, but don't use.
------------------------------------------------------------------------
PasTim's Profile: http://forums.slimdevices.com/member.php?userid=41642
View this thread: http://forums.slimdevices.com/showthread.php?t=103454

_______________________________________________
beta mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/beta

Reply via email to