I've committed a possible fix now. I can't test it myself because my Xcode version doesn't have the 10.6 SDK.
Brecht. On Wed, May 8, 2013 at 8:47 PM, Brecht Van Lommel <[email protected]> wrote: > The way I understand it MAC_OS_X_VERSION_MIN_REQUIRED gives the > minimum OS X version that Blender can run on (which can be lower than > the OS X SDK version). We are building official releases with a 10.6 > minimum version, so changing it to 1070 would cause this code to not > get compiled. > > Defining NSWindowCollectionBehaviorFullScreenPrimary and > NSFullScreenWindowMask if they are not there will probably fix the > issue, similar to what we do for NSEventPhase, will test that. > > Brecht. > > On Wed, May 8, 2013 at 7:53 PM, patrick boelens <[email protected]> wrote: >> Hi Brecht, >> >> Sorry, but I'm not sure what you mean by "this code would be excluded then"? >> >> I get two accounts of 'NSWindowCollectionBehaviorFullScreenPrimary' not >> being declared, and three mentions of an undeclared >> 'NSFullScreenWindowMask', both of which weren't added until 10.7. Maybe I'm >> just missing something obvious again though, wouldn't be the first time. =P >> >>> From: [email protected] >>> Date: Wed, 8 May 2013 19:03:09 +0200 >>> To: [email protected] >>> Subject: Re: [Bf-committers] OSX 10.6 building error since May 6th >>> GHOST_WindowCocoa.mm commit >>> >>> I'm not sure this is correct, for our official builds we require a >>> 10.6 minimum version, so I think this code would be excluded then? >>> Also the first line you changed was already there before this bugfix, >>> and the function toggleFullscreen function is also used in >>> GHOST_SystemCocoa.mm. >>> >>> What is the exact compile error, is it just NSFullScreenWindowMask >>> that is undefined? >>> >>> Thanks, >>> Brecht. >>> >>> On Wed, May 8, 2013 at 6:19 PM, patrick boelens <[email protected]> wrote: >>> > Hey everyone, >>> > >>> > First off, hats off the the team and congrats on getting Blender 2.67 out >>> > into the wild! >>> > >>> > I just updated my source directory and found I couldn't build anymore on >>> > OSX 10.6. This stems from the May 6th commit by Brecht in >>> > GHOST_WindowCocoa.mm; it seems 1060 was used as the >>> > MAC_OSX_VERSION_MIN_REQUIRED where 1070 was meant (the comments even >>> > mention Lion; 10.6 is Snow Leopard. ;)) It's an easy enough fix, but I >>> > uploaded my .diff regardless[1]. >>> > >>> > Cheers! >>> > -Patrick >>> > >>> > [1] http://www.pasteall.org/42060/diff >>> > >>> > _______________________________________________ >>> > Bf-committers mailing list >>> > [email protected] >>> > http://lists.blender.org/mailman/listinfo/bf-committers >>> _______________________________________________ >>> Bf-committers mailing list >>> [email protected] >>> http://lists.blender.org/mailman/listinfo/bf-committers >> >> _______________________________________________ >> Bf-committers mailing list >> [email protected] >> http://lists.blender.org/mailman/listinfo/bf-committers _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
