On 26 Jan 2009, at 4:41 PM, Adam R. Maxwell wrote:

>
> On Jan 26, 2009, at 2:58 PM, Christiaan Hofman wrote:
>
>> Adam, I noticed some leaks in FVColorMenuView, basically anytime a
>> view was created it was leaked, because you did not take into account
>> the initial retain top-level nib objects get. I also improved the
>> archiving so your awakeFromCoder hack is no longer necessary.
>
> Thanks; IIRC I thought NSNib didn't have that issue, although  
> Apple's example demonstrates it pretty clearly.  Oops.
>
> In case anyone's interested, I created a project for FileView last  
> year on googlecode [1].  I no longer recall everything that's  
> changed, but here's a rough summary:
>
> - Rewrite of all image scaling (now uses vImage) and caching (no  
> longer uses DTSource).  This reduced memory footprint, but may be  
> slower in terms of clock time.
>
> - There's also a caching malloc zone that fixes some instrumentation  
> issues with using vm_allocate directly, and avoids a lot of the heap  
> overhead inherent in >16K allocations with OS X's malloc.
>
> - In the view itself, I rewrote the grid layout and fixed some major  
> consistency problems (and drawRect: no longer causes layout  
> changes).  I also factored a bunch of the controller logic out,  
> fixed the bindings support, and added an IB3 palette.  AFAIK this  
> all works, although there's an occasional scroller hiding issue I  
> haven't been motivated to track down.
>
> [1] http://fileview.googlecode.com/

Ah, that's where it went.

Is it worthwhile to move the changes to the bibdesk tree? I also did  
some rewrite of the layout, and they split quite a while ago. So it  
may be quite nontrivial to merge back in.

Christiaan


------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Bibdesk-develop mailing list
Bibdesk-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bibdesk-develop

Reply via email to