Christiaan Those are valid comments. Please find here the revised code with all of the change requests implemented.
However this one here is open: // Reto: Obj-C dummy Question: how do I convert NSDate to a String of YYYY-MM-DD ??? timeSpan.end = [NSDate date]; Reto > A few small things I noted in the code: > > - line 706: [scanner release] should be after the braces (it should always > happen).no need to use valueForKey:, you can directly use the stringValue > method. > - line 714: > - line 646: you don't have to check [child name], because you already know > it's @"title", also I would put the type attribute in a variable because it's > used multiple times. > - line 763: same for @"identifier" and also @"value". > > Also, for efficiency, it may make sense to get some intermediate nodes (like > for static_data and summary), and start further XPaths from them, as you need > several subnodes of them. > > Oh, and definitely no braces around title, that should never be done, it's an > abuse of the bibtex syntax. There is no way to do this automatically, so > users need to do this manually if they want to preserve it. > > As for SVN, we (I) can commit it. Or you can do it when we give you access, > but then you probably also need a new svn checkout and perhaps other stuff to > make it work. > > thanks > Christiaan > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech_______________________________________________ > Bibdesk-develop mailing list > Bibdesk-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
BDSKISIGroupServer.m
Description: Binary data
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ Bibdesk-develop mailing list Bibdesk-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
