It's indeed not necessary. So I'll try to remove the whole time span thing.
I'll re-checkout a working copy with rw permissions and then implement my changes there before trying to commit. Reto On Mar 26, 2014, at 10:42 PM, Christiaan Hofman wrote: > > On Mar 26, 2014, at 21:21, Reto Stöckli wrote: > >> Christiaan >> >> Those are valid comments. Please find here the revised code with all of the >> change requests implemented. >> >> However this one here is open: >> // Reto: Obj-C dummy Question: how do I convert NSDate to a String of >> YYYY-MM-DD ??? >> timeSpan.end = [NSDate date]; >> Reto >> > > First of all: is it really necessary? It is not used by search, and if I > understand the documentation correctly, the whole timespan can be left out in > general, in which case the full time span for the edition is used. Is that > correct? > > Apart from that, to convert a date to a string, you use an NSDateFormatter. > You can see that in NSDate_BDSKExtensions.m. In fact, what you need is the > first part of the standardDescription. > > Also, if you want, you can commit, I've given you svn commit permission. But > you need a working copy with read/write access, and probably some more > authorization configurations. > > Christiaan > >> >>> A few small things I noted in the code: >>> >>> - line 706: [scanner release] should be after the braces (it should always >>> happen).no need to use valueForKey:, you can directly use the stringValue >>> method. >>> - line 714: >>> - line 646: you don't have to check [child name], because you already know >>> it's @"title", also I would put the type attribute in a variable because >>> it's used multiple times. >>> - line 763: same for @"identifier" and also @"value". >>> >>> Also, for efficiency, it may make sense to get some intermediate nodes >>> (like for static_data and summary), and start further XPaths from them, as >>> you need several subnodes of them. >>> >>> Oh, and definitely no braces around title, that should never be done, it's >>> an abuse of the bibtex syntax. There is no way to do this automatically, so >>> users need to do this manually if they want to preserve it. >>> >>> As for SVN, we (I) can commit it. Or you can do it when we give you access, >>> but then you probably also need a new svn checkout and perhaps other stuff >>> to make it work. >>> >>> thanks >>> Christiaan > > > ------------------------------------------------------------------------------ > _______________________________________________ > Bibdesk-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/bibdesk-develop ------------------------------------------------------------------------------ _______________________________________________ Bibdesk-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
