Hi Joseph,
Here is the status of what I have been able to apply to far:
gc_intf: ok
cunicode: already
csystem: ok
inet_aton: ok
inet_pton: ok
getaddrinfo: ok
socket: ok
I have not applied that patches regarding csocket and cdate yet.
Considering cdate.c I don't see why the modification you have applied
is required. The man page for time specifies that the argument can
be optionally null:
-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----
NAME
time - get time in seconds
SYNOPSIS
#include <time.h>
time_t time(time_t *t);
DESCRIPTION
time() returns the time as the number of seconds since the Epoch,
1970-01-01 00:00:00 +0000 (UTC).
If t is non-NULL, the return value is also stored in the memory pointed
to by t.
RETURN VALUE
On success, the value of time in seconds since the Epoch is returned.
On error, ((time_t) -1) is returned, and errno is set appropriately.
-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----|-----
Your patch changes the NULL value sent as argument to time. Is it because you
have observed that MinGW does not support NULL arguments? Is there another
reason that I have missed? Thanks in advance for sharing with us the motivation
for this patch.
Considering csocket.c, I have quickly browsed the patch. I have no particular
problem with it but since it deeply changes the actual implementation.
I need to study it more carefully. I hope to be able to do this in the coming
days. I will come back to you when done.
Thanks again for your contributions.
--
Manuel
