Dear All, Before doing something I shouldn't I want to make sure how to proceed:
a few hours ago, a new version of testthat has been made available in CRAN (v. 1.0.0); this version can be more picky with statements such as expect_output(out, "some message") Now (depending on the details, which I skip here) some of those might fail unless we write: expect_output(print(out), "some message"). This change could lead to failures of some tests (it will for my OncoSimulR package). So my question is: will new tests of BioC 3.3 use the former testthat (0.11) and be frozen at that version, or should we update changes that will prevent failures when testthat us updated to version 1.0? I'd just go ahead and update, but https://www.bioconductor.org/developers/release-schedule/ indicates that we should only change code if there are show-stopper bugs. But whether these are show stopper bugs depends on whether testthat will be upgraded to 1.0 I am inclined to upgrade, but want to make sure that is the right course of action. Best, R. -- Ramon Diaz-Uriarte Department of Biochemistry, Lab B-25 Facultad de Medicina Universidad Autónoma de Madrid Arzobispo Morcillo, 4 28029 Madrid Spain Phone: +34-91-497-2412 Email: rdia...@gmail.com ramon.d...@iib.uam.es http://ligarto.org/rdiaz _______________________________________________ Bioc-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/bioc-devel
