Basically (and this is true for release as well) CRAN packages gets pushed to the build system frequently. I don't know if testthat has been pushed to the devel build setup yet, but it will happen and you will get a problem. If not now, then shortly after release.
So I recommend updating, and adding a version dependence on testthat, like Suggests: testthat (>= 1.0.0) Your package might fail for a few days in devel; you'll have to wait for testthat to be updated. On Thu, Apr 14, 2016 at 9:22 AM, Ramon Diaz-Uriarte <rdia...@gmail.com> wrote: > Dear All, > > Before doing something I shouldn't I want to make sure how to proceed: > > a few hours ago, a new version of testthat has been made available in CRAN > (v. 1.0.0); this version can be more picky with statements such as > > expect_output(out, "some message") > > Now (depending on the details, which I skip here) some of those might fail > unless we write: > > > expect_output(print(out), "some message"). > > > This change could lead to failures of some tests (it will for my OncoSimulR > package). > > > So my question is: will new tests of BioC 3.3 use the former testthat > (0.11) and be frozen at that version, or should we update changes that will > prevent failures when testthat us updated to version 1.0? I'd just go ahead > and update, but > > https://www.bioconductor.org/developers/release-schedule/ > > indicates that we should only change code if there are show-stopper > bugs. But whether these are show stopper bugs depends on whether testthat > will be upgraded to 1.0 > > > I am inclined to upgrade, but want to make sure that is the right course of > action. > > > Best, > > > R. > > > > > -- > Ramon Diaz-Uriarte > Department of Biochemistry, Lab B-25 > Facultad de Medicina > Universidad Autónoma de Madrid > Arzobispo Morcillo, 4 > 28029 Madrid > Spain > > Phone: +34-91-497-2412 > > Email: rdia...@gmail.com > ramon.d...@iib.uam.es > > http://ligarto.org/rdiaz > > _______________________________________________ > Bioc-devel@r-project.org mailing list > https://stat.ethz.ch/mailman/listinfo/bioc-devel [[alternative HTML version deleted]] _______________________________________________ Bioc-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/bioc-devel
