On 10/13/17 3:32 PM, Hervé Pagès wrote:
Hi Stephanie,

Can you provide a little bit more context? Have you observed
conflicts between VariantAnnotation:::asVCF() and other asVCF()
functions defined elsewhere? Any reason why you can't use/import
VariantAnnotation:::asVCF() in your package?

I would prefer to leave VariantAnnotation in "Suggests" rather than "Imports" for performance reasons - it adds substantially to package load time, but will be used only rarely.


Alternatively, have you considered using/defining a coercion method
to VCF instead? That should work (and would be preferred) if you
don't need the extra arguments that an "asVCF" method would allow
you to support.

I will look into coercion methods; thanks for the suggestion! Can one define a coercion method where the "to" class is in a package that's not attached until the method is called (with requireNamespace)?

thanks,
Stephanie


The VCF class is defined in the VariantAnnotation package so it
would be weird to have the asVCF() generic in BiocGenerics.

Cheers,
H.


On 10/13/2017 01:55 PM, Stephanie M. Gogarten wrote:
Can we move the "asVCF" generic to BiocGenerics?

thanks,
Stephanie

_______________________________________________
Bioc-devel@r-project.org mailing list
https://urldefense.proofpoint.com/v2/url?u=https-3A__stat.ethz.ch_mailman_listinfo_bioc-2Ddevel&d=DwICAg&c=eRAMFD45gAfqt84VtBcfhQ&r=BK7q3XeAvimeWdGbWY_wJYbW0WYiZvSXAJJKaaPhzWA&m=0Ri2Pb4ycHLpQX0GgcoL0ZBpK2f15xNE0cEV1MC6d9w&s=6u7LTi87hcmFtZl8tm7tne0VGxLc2kaQj7j3aActGuk&e=



_______________________________________________
Bioc-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/bioc-devel

Reply via email to