On 2/11/07, Randy McMurchy <[EMAIL PROTECTED]> wrote:
> Randy McMurchy wrote these words on 02/11/07 09:45 CST:
> > Hi all,
> >
> > Unless there are objections I'd like to make the following changes to
> > the MesaLib instructions:
>
> 7. There are two sed commands in a row which are identical except that
> they modify different files. This should be consolidated into one sed
> command with the two files as the input files.
There's a couple of things there, actually. I was reluctant to change
them since things were working. But, since you're brought it up...
The first sed is unnecessary. By passing X11_INCLUDES and
EXTRA_LIB_PATH to the Makefile, you can make the build process look
where you want it to. The second one _could_ be worked around by
adding the macro -DDEFAULT_DRIVER_DIR to the OPT_FLAGS we're already
passing. The third one is totally unnecessary as it's only used with
"make install", which we don't do.
1. You could drop all 3 seds:
make linux-dri-x86 \
OPT_FLAGS="$CFLAGS -fno-strict-aliasing
-DDEFAULT_DRIVER_DIR=\\\"${XORG_PREFIX}/lib/X11/modules/dri\\\"" \
X11_INCLUDES="-I${XORG_PREFIX}/include" \
EXTRA_LIB_PATH="-L${XORG_PREFIX}/lib"
2. Just fix the DRI driver path but drop the other 2 seds:
sed -i "s@/usr/X11R6/lib/[EMAIL PROTECTED]/lib/X11/modules@" \
src/glx/x11/dri_glx.c
...
make linux-dri-x86 \
OPT_FLAGS="$CFLAGS -fno-strict-aliasing" \
X11_INCLUDES="-I${XORG_PREFIX}/include" \
EXTRA_LIB_PATH="-L${XORG_PREFIX}/lib"
3. Just drop the sed to Makefile.template since it's not needed and
keep everything else as is.
Do you have any interest in these changes?
--
Dan
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
