Dan Nicholson wrote these words on 02/11/07 11:38 CST:
> The first sed is unnecessary. By passing X11_INCLUDES and
> EXTRA_LIB_PATH to the Makefile, you can make the build process look
> where you want it to.
I wouldn't say it as "is unnecessary". I think better could be
"can be omitted". :-) And I like the idea.
> The second one _could_ be worked around by
> adding the macro -DDEFAULT_DRIVER_DIR to the OPT_FLAGS we're already
> passing.
I like this idea as well.
> The third one is totally unnecessary as it's only used with
> "make install", which we don't do.
Agreed.
> 1. You could drop all 3 seds:
>
> make linux-dri-x86 \
> OPT_FLAGS="$CFLAGS -fno-strict-aliasing
> -DDEFAULT_DRIVER_DIR=\\\"${XORG_PREFIX}/lib/X11/modules/dri\\\"" \
> X11_INCLUDES="-I${XORG_PREFIX}/include" \
> EXTRA_LIB_PATH="-L${XORG_PREFIX}/lib"
Nice.
> Do you have any interest in these changes?
Sure. I'd like DJ to throw some input in, but I think the changes
are good. I also noticed that the entire build/install commands
could be consolidated together and descriptions of what's going on
then put in the "Command Explanation" section. It could be much more
condensed. Removing the seds will make a big difference.
Thanks for the tips, Dan.
--
Randy
rmlscsi: [bogomips 1003.26] [GNU ld version 2.16.1] [gcc (GCC) 4.0.3]
[GNU C Library stable release version 2.3.6] [Linux 2.6.14.3 i686]
12:03:00 up 32 days, 12:17, 1 user, load average: 0.07, 0.11, 0.03
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
