Dan Nicholson wrote: > Thanks for looking at this, Bruce. > > On 4/20/07, Bruce Dubbs <[EMAIL PROTECTED]> wrote: >> Dan Nicholson wrote:
>> Why is it expat *or* pkgconfig? These packages don't seem like they >> would do the same thing. > > I should have commented on this. You either need expat or libxml2, but > the libxml2 check uses pkg-config. So > > expat || ( libxml2 && pkg-config ) > > I couldn't think of the right way to say this. It still seems weird. There does not seem to be much functional overlap between expat and libxml2. I think you should add the parens and also add a sentence explaining it since it is so unusual. Or how about: "expat or both libxml2 and pkg-config" >> Do the Python bindings not get built by default any more? You removed >> the --disable-python switch so I would guess that they don't. > > All the bindings are split into separate packages: glib, qt3, python, > java. Randy said he would take on the task of handling the bindings. > Look a little earlier in this thread. > > We'd agreed to put the core and bindings on separate pages to keep > down the clutter. I think he's planning on having it look like the > Perl modules page. Is that alright? I understood that, but my question remains. "I am a user that wants to build D-Bus/HAL, but I really don't care about the bindings. I also don't have Python installed. Will the package build OK?" That is not clear to me right now. If it does build OK, with or without warnings, then what is there seems reasonable. I was just asking because the older text implies that it won't build without Python unless you add the switch >> In making these types of reviews, wouldn't it be better to just build >> the book on quantum or anduin and point to that so we can see everything >> in context? > > Sure, I can do that. > > http://www.linuxfromscratch.org/~dnicholson/blfs-dbus/general/dbus.html That is helpful. I can see a problem with the discussion of the test suite though. It seems incomplete as it says that a special build must be made with configure switches, but it doesn't say which switch(es) or what the test command it. I think a better way is to start the section and say that a special build is needed if you want to test: configure --enable-tests && make && make check && make distclean And then go into the full build instructions. -- ruce -- http://linuxfromscratch.org/mailman/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
