On 16/03/2019 16:12, Bruce Dubbs via blfs-dev wrote: > On 3/16/19 9:40 AM, Pierre Labastie via blfs-dev wrote: >> On 16/03/2019 12:50, Bruce Dubbs via blfs-dev wrote: >>> On 3/16/19 4:39 AM, Pierre Labastie via blfs-dev wrote: >>> >>> >>>> - mesa-19.0.0: running "make -C ../xdemos DEMOS_PREFIX=$XORG_PREFIX" >>>> generates >>>> an error because libGL cannot be found. I guess it wouldn't show up if a >>>> previous version of mesa were installed, since there is /usr/lib/libGL.so. >>>> I do not know what would be a fix, but my guess is that we should look at >>>> the >>>> source of the demos and see whether they have been ported to meson/ninja. >>>> Otherwise, we may need to run configure for those >>> >>> The Makefile for xdemos is hard coded -- there is no configure. Looking at >>> it, it has: >>> >>> DEMOS_LDFLAGS = -L../lib$(EXT) -lGL $(X11_LIBS) -lm >>> >>> At the time xdemos is first built, ./build/src/glx/libGL.so exists, but is >>> not >>> yet installed. For builds where $XORG_PREFIX/lib/libGL* already exists, >>> there >>> is no problem. >>> >>> For a first install, I can think of a couple of solutions: >>> >>> 1. Add a variable LIBRARY_PATH=$PWD/src/glx to the make xdemos line. >> >> $PWD/lib? > > No. While building in mesa-19.0.0/build, the libraries show up in ./src/glx. > >>> 2. Move the make xdemos line to after ninja install of the main package. >> >> Simpler (as you and Thomas seem to think too)? Actually, it prevents the >> demos >> from being linked to an older library. But you know I do not like having two >> packages on the same page :), unless both can be merged, which means >> installing everything at the same time. > > It's not really much of a package and we've been doing xdemos with mesa from > the very beginning of BLFS. > >>> >>> The issue is that testing would require a complete reinstall of xorg. >>> >>> I suppose I could just rename /opt/xorg to /opt/xorg.save and rebuild just >>> xorg thru mesa and then restore the original by removing the new partial >>> xorg >>> and renaming back. I lean towards moving the xdemos build to after the mesa >>> install. >>> >>> Is that something you could do relatively quickly with jhalfs? >>> >>> On second thought, just removing/renaming $XORG_PREFIX/lib/libGL.so >>> (temporarily) and testing the mesa build may be enough to test changes. >> >> Agreed. I can do that with porg (rather than jhalfs): exit Xorg, porg -r >> mesa, >> then try to build, using the script jhalfs generated, after adequate >> modification. I think I'll try a sed to the demos Makefile... (or update the >> patch) > > Let us know... >
So, the problem is that the Makefile in xdemos does not honour LIBRARY_PATH. So the line above should be changed to: DEMOS_LDFLAGS = -L$(LIBRARY_PATH) -lGL $(X11_LIBS) -lm I think the best is to modify the patch for that. Then the xdemos build can be done with: make -C ../xdemos DEMO_PREFIX=$XORG_PREFIX LIBRARY_PATH=$PWD/src/glx (tested ok) Note that "make install" does not need the LIBRARY_PATH. Pierre -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
