On 23/03/2019 00:40, Ken Moffat via blfs-dev wrote: > On Fri, Mar 22, 2019 at 10:54:42PM +0100, Pierre Labastie via blfs-dev wrote: >> >> Slightly off topic: libssh2 is nowhere mentioned as a dep of vlc. Shouldn't >> it >> be added? (together with a description of the --disable-sftp option) >> > Probably, and possibly. > > > Identifying the exact dependency chain which pulls in libssh2 seems > less urgent (i.e. at the moment I'm not sure if it is the only > dependency, or one of a series). >
What I can tell is that libssh2 is not in the recommended dependency chain of vlc, at least according to the deps noted in the book (well, there may be a bug in jhalfs, in which case, nothing is sure). After reading configure.ac, I think the default for --enable-sftp is "auto", and that only libssh2 presence is needed to trigger building the sftp module. Now, back to the original topic: LIBSSH2_HOSTKEY_TYPE_ECDSA_256 has been added in the git repository of libssh2 since the last release. In modules/access/sftp.c, this macro is used only if LIBSSH2_VERSION_NUM >= 0x010801. This is the bug: libssh2 will include the modification only at the next minor version. So no change in libssh2, it's a change in vlc, I think. There is a ticket for that upstream https://trac.videolan.org/vlc/ticket/22060 Seems to be closed/fixed (see attached patch). I suggest: sed -i '/LIBSSH2_VERSION_NUM/s/10801/10900/' modules/access/sftp.c This should be added to the book, since otherwise, people get a somewhat hard to understand error when they have libssh2 installed. But waiting for other advises. Pierre Pierre
>From db381f6edeac9d70b7545a72bc2840f42266d655 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= <[email protected]> Date: Wed, 20 Mar 2019 05:20:30 +0200 Subject: [PATCH 1/2] sftp: fix version for ECDSA known hosts (fixes #22060) 1.8.x is a stable branch, separate from the feature branch that contains the ECDSA support. (cherry picked from commit 11449b5cd8b415768e010d9b7c1d6ba3cea21f82) Signed-off-by: Konstantin Pavlov <[email protected]> --- modules/access/sftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/access/sftp.c b/modules/access/sftp.c index 5bc054d310..6ea58654ed 100644 --- a/modules/access/sftp.c +++ b/modules/access/sftp.c @@ -306,7 +306,7 @@ static int Open( vlc_object_t* p_this ) case LIBSSH2_HOSTKEY_TYPE_DSS: knownhost_fingerprint_algo = LIBSSH2_KNOWNHOST_KEY_SSHDSS; break; -#if LIBSSH2_VERSION_NUM >= 0x010801 +#if LIBSSH2_VERSION_NUM >= 0x010900 case LIBSSH2_HOSTKEY_TYPE_ECDSA_256: knownhost_fingerprint_algo = LIBSSH2_KNOWNHOST_KEY_ECDSA_256; break; -- 2.20.1
-- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
