On 3/23/19 5:56 PM, Ken Moffat via blfs-dev wrote:
On Sat, Mar 23, 2019 at 09:17:48AM +0100, Pierre Labastie via blfs-dev wrote:
On 23/03/2019 00:40, Ken Moffat via blfs-dev wrote:
On Fri, Mar 22, 2019 at 10:54:42PM +0100, Pierre Labastie via blfs-dev wrote:
Slightly off topic: libssh2 is nowhere mentioned as a dep of vlc. Shouldn't it
be added? (together with a description of the --disable-sftp option)
Probably, and possibly.
Identifying the exact dependency chain which pulls in libssh2 seems
less urgent (i.e. at the moment I'm not sure if it is the only
dependency, or one of a series).
What I can tell is that libssh2 is not in the recommended dependency chain of
vlc, at least according to the deps noted in the book (well, there may be a
bug in jhalfs, in which case, nothing is sure).
After reading configure.ac, I think the default for --enable-sftp is "auto",
and that only libssh2 presence is needed to trigger building the sftp module.
After reading configure (I usuallyfind that easier than the .ac
version) I agree.
Now, back to the original topic:
LIBSSH2_HOSTKEY_TYPE_ECDSA_256 has been added in the git repository of libssh2
since the last release. In modules/access/sftp.c, this macro is used only if
LIBSSH2_VERSION_NUM >= 0x010801. This is the bug: libssh2 will include the
modification only at the next minor version. So no change in libssh2, it's a
change in vlc, I think.
There is a ticket for that upstream https://trac.videolan.org/vlc/ticket/22060
Seems to be closed/fixed (see attached patch).
I suggest:
sed -i '/LIBSSH2_VERSION_NUM/s/10801/10900/' modules/access/sftp.c
I salute your skills (as I said, google found nothing useful for
me). I've gone back to an 8.4 system, with upgraded ssh2, and that
too failed to build, and has now built with that sed. Thanks.
This should be added to the book, since otherwise, people get a somewhat hard
to understand error when they have libssh2 installed. But waiting for other
advises.
Pierre
When I was looking through my log to find out what was wrong, I
noticed some dependencies which were either familiar to me because
of this week's firefox shenanigans, or were things I have sometimes
built. There may be others:
https://sourceforge.net/p/soxr/wiki/Home/ resampler
https://code.videolan.org/videolan/dav1d decoder
https://aomedia.googlesource.com/aom/ codec
I suppose libssh2 belongs in 'Optional features and packages'.
I'm inclined to put the other three into 'Optional codec plugins',
was not sure about soxr but libschroedinger is already among the
codec plugins.
Do you wish to do this, or shall I ?
I will, thanks for confirming.
Pierre
--
http://lists.linuxfromscratch.org/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
