If we're first to implement, we should always be asking for design guidance from the TAG. That a feature originates in the CSS WG is not a pass for design review (although I know CSS WG participants often wish it were).
Best, Alex On Wednesday, May 25, 2022 at 11:42:31 PM UTC-7 [email protected] wrote: > Thanks for feedbacks! > > 1. Explainer : I added an csswg-drafts issue link( > https://github.com/w3c/csswg-drafts/issues/6965) into explainer. It has > been re-opened due to the fullscreen spec. > > 2. fullscreen spec : As mentioned, issue has been re-opened due to this. > Further discussion is needed. > > 3. TAG review : I think it would not needed since it's an existing spec > discussed. If not, please let me know :) > > 4. Gecko vendor signal : I set gecko's signal to 'Shipped/Shipping' as the > doc(bit.ly/blink-signals) defines 'Shipped/Shipping' as 'Link to public > documentation or bug/issue'. I'm not sure which signal would be right if > there is an open issue. > > 5. WPT link :There were some differences between what was written in > chromestatus and I2S. I added WPT test links but on I2S that is not shown. > As Emillo mentioned, WPT links are as follows. > http://wpt.live//css/selectors/modal-pseudo-class.html > https://wpt.fyi/results/css/selectors/modal-pseudo-class.html > > Thanks again! > > > 2022년 5월 26일 목요일 오전 1시 0분 45초 UTC+9에 [email protected]님이 작성: > >> I'd like to see an explainer and completed TAG review before moving >> forward. Could this perhaps be going to OT instead? >> >> On Wednesday, May 25, 2022 at 3:44:22 AM UTC-7 Emilio Cobos Alvarez wrote: >> >>> On 5/25/22 09:38, Manuel Rego Casasnovas wrote: >>> > There are these tests for ":modal": >>> > * http://http://wpt.live//css/selectors/modal-pseudo-class.html >>> > * >>> > http:// >>> http://wpt.live//css/selectors/invalidation/modal-pseudo-class-in-has.html >>> > >>> > They are for <dialog>, but it looks there are no tests for the >>> > fullscreen case. >>> >>> It isn't clear from the resolution[1] that this should apply to >>> fullscreen, and it doesn't seem like WebKit's implementation does that >>> (it seems a bit weird that it would since fullscreen at least in Gecko >>> isn't modal / doesn't make the rest of the page inert...). >>> >>> I commented on the spec issue about this. >>> >>> -- Emilio >>> >>> [1]: >>> https://github.com/w3c/csswg-drafts/issues/6965#issuecomment-1118033655 >> >> -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/224a52cb-fdd7-4f6a-afb9-09e47fef2435n%40chromium.org.
