LGTM1. I think the loss of the domain restriction is quite unfortunate, but I understand why you landed on that as the simplest path for deployment. My feeling is that folks are going to have to rework things in any event, and this would be an opportune time to revisit same-site-but-cross-origin cookie access within partitions to make the eventual work to align cookies with the origin model easier in the future. At the same time, I recognize that that's a problem that's not made any worse by shipping this feature, and I'll defer to y'all on the short-term deployment tradeoffs.
On the issues, I'd appreciate y'all taking another pass through to make sure there aren't any decisions lurking in the tracker that will be hard to revisit once we ship. I'd also appreciate you finalizing the resolution to https://github.com/privacycg/CHIPS/issues/40, which looks like there's still some ongoing discussion. That's the only issue I saw in a very quick pass that looked like it clearly required resolution before shipping, but y'all are more familiar with the conversations on the topic than I am. :) Thanks! -mike On Friday, November 11, 2022 at 6:12:10 PM UTC+1 Mike Taylor wrote: > On Friday, November 11, 2022 at 10:22:41 AM UTC-5 Mike Taylor wrote: > >> Unless we consider Cookie Store to be a normative requirement of CHIPS >> (and I don't think we do), that doesn't seem like a great outcome. Can I >> ask what WPT is missing to be able to write these tests in a cross-browser >> fashion? A better outcome would be to add the missing functionality to WPT >> itself. >> > > After looking at the failing test in question, I see that you're testing > that CookieStore can correctly handle a partitioned cookie. Maybe that test > should live in the cookie-store directory as follow-up work, but a quick > workaround to feature-detect like you described seems fine for now. > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/c54a9e36-2a77-4a13-8453-3a0aeb1f316an%40chromium.org.
